Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python/semantic_kernel/memory/volatile_memory_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -213,13 +213,14 @@ async def get_nearest_match(
Returns:
Tuple[MemoryRecord, float]: The record and the relevance score.
"""
return self.get_nearest_matches(
results = await self.get_nearest_matches(
collection_name=collection_name,
embedding=embedding,
limit=1,
min_relevance_score=min_relevance_score,
with_embeddings=with_embedding,
)
return results[0]

async def get_nearest_matches(
self,
Expand Down
33 changes: 33 additions & 0 deletions python/tests/unit/memory/test_volatile_memory_store.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# Copyright (c) Microsoft. All rights reserved.

import warnings

import numpy as np
import pytest

from semantic_kernel.memory.memory_record import MemoryRecord
from semantic_kernel.memory.volatile_memory_store import VolatileMemoryStore


@pytest.fixture
async def store() -> VolatileMemoryStore:
with warnings.catch_warnings():
warnings.simplefilter("ignore", DeprecationWarning)
memory_store = VolatileMemoryStore()
await memory_store.create_collection("test")
await memory_store.upsert("test", MemoryRecord.local_record("a", "text a", None, None, np.array([1.0, 0.0])))
await memory_store.upsert("test", MemoryRecord.local_record("b", "text b", None, None, np.array([0.0, 1.0])))
return memory_store


async def test_get_nearest_match_returns_tuple(store: VolatileMemoryStore):
record, score = await store.get_nearest_match("test", np.array([1.0, 0.1]))

assert record._id == "a"
assert score == pytest.approx(0.995, abs=1e-3)


async def test_get_nearest_match_respects_min_relevance_score(store: VolatileMemoryStore):
record, _ = await store.get_nearest_match("test", np.array([0.1, 1.0]), min_relevance_score=0.5)

assert record._id == "b"
Loading