feat(oauth): add telemetry for multioauth/state

[Lily Du (lilyydu)]

Summary

aligns PY OAuth and state telemetry with TS and C#

• records a separate verifyState span and metric for each OAuth connection attempt
• adds sign-in telemetry for cached-token, card-sent, and failure outcomes
• adds exception-aware spans for state load, save, and delete operations
• preserves existing OAuth routing, callback, response, and state behavior
• adds focused coverage for multi-connection attempts and telemetry error paths

[Copilot]

🟢 Approval recommended

The changes are well-covered by focused tests and appear behavior-preserving; only minor log-message formatting nits were found.

Pull request overview

This PR extends the Python Teams SDK’s diagnostics to align OAuth and state telemetry with the TypeScript/C# implementations, adding spans/metrics for key OAuth outcomes and state persistence operations while keeping the functional OAuth/state behavior intact.

Changes:

• Add exception-aware OpenTelemetry spans around state load/save/delete operations in TurnStateLoader.
• Record OAuth signin span/metrics with outcome attribution (cached token vs sign-in card vs failure) in OAuthFlow.sign_in.
• Refactor signin/verifyState probing to emit per-connection telemetry and add targeted tests covering multi-connection attempts and error paths.

File summaries

File	Description
packages/apps/src/microsoft_teams/apps/state/loader.py	Wrap state operations with traced spans and exception recording.
packages/apps/src/microsoft_teams/apps/oauth_flow.py	Add signin span + metrics with result/error attribution and duration.
packages/apps/src/microsoft_teams/apps/diagnostics/_constants.py	Introduce new OAuth operation/result constants and new span names for state + signin.
packages/apps/src/microsoft_teams/apps/app_oauth.py	Emit verify_state telemetry per candidate connection attempt; preserve routing behavior.
packages/apps/tests/test_state.py	Add coverage ensuring state spans are created and storage exceptions are recorded.
packages/apps/tests/test_oauth_flow.py	Add coverage for signin telemetry across success, card-sent, and failure paths.
packages/apps/tests/test_app_oauth.py	Add coverage asserting per-connection verify_state spans/metrics across multiple candidates.

Review details

Suppressed comments (2)

packages/apps/src/microsoft_teams/apps/app_oauth.py:757

• This error log message concatenates two f-strings without a separating space, which yields ... in conversationc1: in logs.

                    logger.error(
                        f"Error verifying sign-in state for user {activity.from_.id} in conversation"
                        f"{activity.conversation.id}: {e}"
                    )

packages/apps/src/microsoft_teams/apps/app_oauth.py:776

• Same missing-space issue in the exception-path error log: two adjacent f-strings are concatenated without whitespace, producing ... in conversationc1:.

                    logger.error(
                        f"Error verifying sign-in state for user {activity.from_.id} in conversation"
                        f"{activity.conversation.id}: {e}"
                    )

• Files reviewed: 7/7 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.