Clarify GitHub Actions reporting setup - #10774
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Note
🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.
Review Summary
Verdict: All clear ✅
This PR adds a helpful hint message when unknown CLI options are detected, pointing users to --help and suggesting they check extension registration. The change is minimal, well-scoped, and correctly implemented.
Changes reviewed
| Area | Assessment |
|---|---|
CommandLineOptionsValidator |
Hint appended after all unknown-option errors, before returning — correct placement |
PlatformResources.resx |
New CommandLineUnknownOptionsHint resource with proper {Locked="'--help'"} scoping (includes surrounding quotes to avoid locking substrings in translatable words) |
*.xlf files |
All 13 locale files updated with state="new" entries — consistent with UpdateXlf regeneration |
PACKAGE.md / README.md |
Documentation for --report-gh extension enablement added |
| Unit test | CommandLineHandlerTests updated to expect the new hint in the error message |
| Acceptance test | HelpInfoTests wildcard pattern updated to include the hint line |
Dimensions assessed
20 of 22 dimensions clean (N/A: Threading & Concurrency, IPC & Serialization). No findings to report.
Notable positives:
- Localization follows repo conventions precisely —
{Locked="'--help'"}includes the single quotes, avoiding the substring-locking pitfall called out in the repo guidelines. - No public API surface added.
- Both unit and acceptance tests are updated to cover the new behavior.
There was a problem hiding this comment.
Pull request overview
Improves guidance for unavailable Microsoft.Testing.Platform extension options, particularly GitHub Actions reporting.
Changes:
- Adds a recovery hint for unknown options.
- Tests the updated diagnostic output.
- Documents enabling GitHub Actions reporting through MSTest.Sdk.
Show a summary per file
| File | Description |
|---|---|
CommandLineOptionsValidator.UnknownAndBootstrapValidation.cs |
Appends the recovery hint. |
PlatformResources.resx |
Defines the localized hint. |
PlatformResources.cs.xlf |
Adds Czech localization metadata. |
PlatformResources.de.xlf |
Adds German localization metadata. |
PlatformResources.es.xlf |
Adds Spanish localization metadata. |
PlatformResources.fr.xlf |
Adds French localization metadata. |
PlatformResources.it.xlf |
Adds Italian localization metadata. |
PlatformResources.ja.xlf |
Adds Japanese localization metadata. |
PlatformResources.ko.xlf |
Adds Korean localization metadata. |
PlatformResources.pl.xlf |
Adds Polish localization metadata. |
PlatformResources.pt-BR.xlf |
Adds Portuguese localization metadata. |
PlatformResources.ru.xlf |
Adds Russian localization metadata. |
PlatformResources.tr.xlf |
Adds Turkish localization metadata. |
PlatformResources.zh-Hans.xlf |
Adds Simplified Chinese localization metadata. |
PlatformResources.zh-Hant.xlf |
Adds Traditional Chinese localization metadata. |
CommandLineHandlerTests.cs |
Updates the unit-test expectation. |
HelpInfoTests.cs |
Updates the acceptance-test expectation. |
MSTest.Sdk/README.md |
Documents ClassicEngine opt-in. |
MSTest.Sdk/PACKAGE.md |
Adds NuGet-facing setup guidance. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 19/19 changed files
- Comments generated: 1
- Review effort level: Balanced
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
🧪 Expert test review — PR #10774The only test-file changes in this PR are single-line additions of an expected output string (
No new test methods were added and no test logic, assertions, or structure changed beyond adding this expected line to match production behavior. There is nothing substantive to grade or flag — the updates are correct and consistent with the new resource string being introduced. This advisory comment was generated automatically. Grades are heuristic and informational — they do not block merging. Re-run with
|
|
Warning Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding. What happenedThe threat detection results could not be parsed. Review the workflow run logs for details. 🧵 Parallel-safety audit — PR #10774Nothing audited here touches process-global state, shared filesystem paths, or The only test-file changes are single-line additions to expected wildcard-match string literals within existing, unmodified test methods:
No lifecycle members ( Audited Re-run with
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
MSTest.Sdk's default ClassicEngine profile does not include
Microsoft.Testing.Extensions.GitHubActionsReport, so passing--report-ghwithout opting in fails as an unknown option with little recovery guidance. This is particularly confusing alongside the third-partyGitHubActionsTestLogger, which exposes the separate--report-githuboption.This change:
--helpand explaining that extension options require a referenced and registered extension--report-ghin both repository and NuGet-facing guidance--report-ghto avoid a breaking rename or collision withGitHubActionsTestLogger's--report-githubValidation: