Skip to content

chore(deps-dev): aggregate compatible Dependabot updates (ESLint 10) - #121

Merged
Bill Schnurr (bschnurr) merged 2 commits into
mainfrom
chore/aggregate-dependabot-2026-10-16
Oct 16, 2026
Merged

Bill Schnurr (bschnurr) merged 2 commits into
mainfrom
chore/aggregate-dependabot-2026-10-16

Conversation

@bschnurr

@bschnurr Bill Schnurr (bschnurr) commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Summary

Consolidates the compatible updates from the open Dependabot PRs, on top of the updates already merged in #116.

  • Upgrade ESLint 8.57.1 to 10.12.0, Chai 6.2.2 to 6.3.0, and Mocha 12.0.2 to 12.0.3 from the replacement grouped PR chore(deps-dev): bump the all-npm group across 1 directory with 4 updates #120.
  • Migrate .eslintrc.json to eslint.config.mjs, preserving the existing warning-level rules and ignored paths.
  • Remove the redundant --ext ts lint option and document linting and the pinned development Node.js version.

Dependabot PR disposition

PR Update Disposition
#95 actions/setup-node 7.0.0 Already merged through #116; closed as superseded.
#96 actions/setup-python 7.0.0 Already merged through #116; closed as superseded.
#102 @typescript-eslint/eslint-plugin 8.70.0 Already merged through #116; closed as superseded.
#104 @typescript-eslint/parser 8.71.0 Already merged through #116; closed as superseded.
#109 dotenv 18.0.4 Already merged through #116; closed as superseded.
#118 ESLint 10.11.0 and TypeScript 7.0.2 Replaced by Dependabot with #120 during consolidation.
#120 Chai 6.3.0, ESLint 10.12.0, Mocha 12.0.3, TypeScript 7.0.2 All compatible updates covered here; leave #120 open to track deferred TypeScript 7.

TypeScript remains at 6.0.3: the current typescript-eslint parser and plugin declare TypeScript >=4.8.4 <6.1.0 support, and the previous TypeScript 7 attempt failed in the parser. No peer-dependency overrides or unsupported compiler/parser combination is introduced.

Validation

  • npm ci --no-audit --no-fund
  • npm run lint (no errors; two unused-disable warnings in existing source)
  • npm run build
  • npm test (145 passing with Chai 6.3.0 and Mocha 12.0.3)
  • Executable ESLint API checks confirm the existing rules report violations and declaration/output paths remain ignored.
  • git diff --check

Upgrade ESLint to 10 and migrate the existing rules and ignores to flat config. Keep TypeScript 6 until typescript-eslint supports TypeScript 7.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 1b110d11-452b-447a-b91d-2ad62a6bee50
…ot group

Include Chai 6.3.0, Mocha 12.0.3, and the ESLint 10.12.0 range from #120. Continue deferring unsupported TypeScript 7.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 1b110d11-452b-447a-b91d-2ad62a6bee50
@heejaechang

Copy link
Copy Markdown

🔒 Automated review in progress — Heejae Chang (@heejaechang) is auto-reviewing this PR.

@heejaechang

Copy link
Copy Markdown

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: Verification was blocked by unavailable offline dependencies. The container&#x27;s Node.js version matched the pinned 24.17.0, but npm ci failed with ENOTCACHED for uri-js. Lint, build, and targeted Mocha tests could not run, so the PR&#x27;s validation claims remain unconfirmed. The PR adds no tests.

Test runs: 1 passed, 4 not run

  • ⚠️ Not run | ESLint flat-configuration validation | npm run lint
  • ⚠️ Not run | TypeScript build | npm run build
  • ⚠️ Not run | Targeted Chai and Mocha compatibility tests | npm run pretest && node ./node_modules/mocha/bin/mocha.js --ui tdd --require out/tests/_setup.js out/tests/server.test.js out/tests/settings.test.js out/tests/activation.test.js --timeout 10000
  • ⚠️ Not run | Offline dependency preparation | npm ci --offline --no-audit --no-fund
  • ✅ Passed | Dependency and test discovery | printf 'PROFILE=%s\n' "$AUTOMATION_SANDBOX_PROFILE"; node --version; npm --version; git diff --name-only HEAD~1 HEAD; printf '\nNode pin\n'; cat .nvmrc; printf '\nPackage\n'; cat typescript/package.json; printf '\nTest config\n'; cat typescript/tsconfig.test.json; printf '\nDependency availability\n'; test -d typescript/node_modules && printf 'node_modules present\n'; printf '\nTest paths\n'; find typescript -maxdepth 4 -type f ( -name 'test' -o -name 'mocha' ) -not -path '/node_modules/' | head -70
⚠️ ESLint flat-configuration validation diagnostic output
Blocked by offline dependency installation failure.
⚠️ TypeScript build diagnostic output
Blocked by offline dependency installation failure.
⚠️ Targeted Chai and Mocha compatibility tests diagnostic output
Selected existing server, settings, and activation tests could not run because dependency preparation failed.
⚠️ Offline dependency preparation diagnostic output
[container exit=1]
npm error code ENOTCACHED
npm error request to https://ms-feed-25.pkgs.visualstudio.com/1es-public/_packaging/npm-public/npm/registry/uri-js/-/uri-js-4.4.1.tgz failed: cache mode is 'only-if-cached' but no cached response is available.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@heejaechang Heejae Chang (heejaechang) added the review-auto:approved Automated review: no blocking findings (approval posted). label Oct 16, 2026
@bschnurr
Bill Schnurr (bschnurr) merged commit bf458f1 into main Oct 16, 2026
22 checks passed
@bschnurr
Bill Schnurr (bschnurr) deleted the chore/aggregate-dependabot-2026-10-16 branch October 16, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Management of dependencies, Dependabot PRs, etc review-auto:approved Automated review: no blocking findings (approval posted).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants