Repository navigation
fix: memory leak in telemetry reporter - #1137
Open
Simon Siefke (SimonSiefke) wants to merge 3 commits into
Open
Simon Siefke (SimonSiefke) wants to merge 3 commits into
Simon Siefke (SimonSiefke) wants to merge 3 commits into
Conversation
Rich Chiodo (rchiodo)
added
the
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Each debugger telemetry event creates a reporter because the reporter returned by the factory is never saved. The reporters are not disposed when the extension deactivates.
Change
Reuse the cached reporter for subsequent events, and dispose it during extension deactivation.
Before
When starting and stopping a Flask debug session 17 times, telemetry loggers and their callbacks in the extension host grow by 119:
After
No more leak detected.
Test Video
video.webm
AI disclosure: Model: GPT 6.1 Sol. Worktime: 12 min