Repository navigation
Fix native dependency installation in signing jobs - #1142
Open
Bill Schnurr (bschnurr) wants to merge 1 commit into
Open
Bill Schnurr (bschnurr) wants to merge 1 commit into
Bill Schnurr (bschnurr) wants to merge 1 commit into
Conversation
Skip dependency lifecycle scripts when installing tooling for prebuilt VSIX signing, then initialize only the vsce signing binary. This avoids rebuilding windows-process-tree with an unsupported Visual Studio toolchain. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 35aea860-84b7-4f12-88da-cff7120df961
Bill Schnurr (bschnurr)
added
the
bug
Bill Schnurr (bschnurr)
enabled auto-merge (squash)
November 6, 2026 23:10
Bill Schnurr (bschnurr)
disabled auto-merge
November 6, 2026 23:11
Member
Author
|
Follow-up investigation found this PR targets an unused local signing template. The pre-release pipeline imports azure-pipelines/extension/templates/jobs/publish-extension.yml from DevDiv/Pylance-Eng, which invokes ../steps/sign.yml in that shared repository. This change therefore does not fix build 15947122. Auto-merge has been disabled; do not merge this PR as the build fix. The native-install correction belongs in the active shared Pylance-Eng signing template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm ci --ignore-scriptsto avoid rebuilding@vscode/windows-process-tree: the bundlednode-gypcannot recognize the agent's Visual Studio 18 installation.npm rebuild @vscode/vsce-signexplicitly so manifest generation and signature verification retain their required executable. Extension build jobs and signature enforcement are unchanged.Validation
npm run lint.The Azure signing pipeline has not been rerun locally; end-to-end signing still requires Azure CI.