Repository navigation
Parse JSON grammars with mixed-case extensions - #305
Open
Ammann Labs (agammann) wants to merge 1 commit into
Open
Ammann Labs (agammann) wants to merge 1 commit into
Ammann Labs (agammann) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseRawGrammarselects the JSON parser only when a filename ends in lowercase.json. A valid JSON grammar namedexample.JSONorexample.Jsonis sent to the PLIST parser and fails withNear offset 1: expected <.Make the extension check case insensitive. The regression test exercises both filename variants against the existing lowercase behavior.
Reproduction
On
mainatdec096bc6ab91710e13023a00d029b8195e26c60, this throws from the PLIST parser. With the fix, it parses the JSON grammar.Validation
npm ci,npm run compile, andnpm testpass: 268 tests passed and one existing test was skipped.git diff --checkpasses.