Repository navigation
Replace typed-rest-client with global fetch - #1339
Open
Trivikram Kamat (trivikr) wants to merge 1 commit into
Open
Trivikram Kamat (trivikr) wants to merge 1 commit into
Trivikram Kamat (trivikr) wants to merge 1 commit into
Conversation
typed-rest-client was only used by PublicGalleryAPI, so it can go now
that Node 22 has a built-in fetch.
Keep the 'vsce' User-Agent that HttpClient('vsce') used to send, and
add a status check: a non-2xx response now throws with the gallery's
error message, or the HTTP status if there isn't one. Before, it
surfaced as an unclear JSON parse error.
Trivikram Kamat (trivikr)
force-pushed
the
remove-typed-rest-client
branch
from
October 4, 2026 17:48
80ac55a to
d680746
Compare
Author
|
cc Benjamin Christopher Simmonds (@benibenj) Can you please review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typed-rest-clientwas only used byPublicGalleryAPI(src/publicgalleryapi.ts), so this swaps it for the built-infetchthat comes with Node 22, and removes it fromdependencies.post()now callsfetchand still sends theUser-Agent: vsceheader thatHttpClient('vsce')used to set.messagewhen the body has one, and otherwise withGallery request failed: <status> <statusText>. Before, these surfaced as an unclear JSON parse error. The existingerrorCodecheck is still there.