Fix folder ThemeIcon causing incorrect tree level inset#323694
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix folder ThemeIcon causing incorrect tree level inset
Fix folder ThemeIcon causing incorrect tree level inset
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A custom tree view parent item using
ThemeIcon("folder")rendered its children at the wrong tree-level inset, while any other icon aligned correctly.Root cause:
Aligner.hasIconintreeView.tsdecided whether an item "has an icon" by deferringfile/folderThemeIcons to the file icon theme (folderrequiredhasFileIcons && hasFolderIcons). ButTreeRendereractually draws afile/folderThemeIconas an always-present codicon whenever the item has no resource (pershouldShowThemeIcon). The mismatch madealignIconWithTwistytreat the parent as icon-less and pick the wrong branch, shifting the children's inset.Changes:
Aligner.hasIcon— treat anyThemeIconthat renders as a codicon as having an icon, mirroring the renderer:file/foldericons on items that do have a resource still defer to the file icon theme, unchanged.