Repository navigation
Use report-question icon for sessions needing attention - #340329
Merged
Elijah King (eli-w-king) merged 5 commits intoOct 9, 2026
Merged
Elijah King (eli-w-king) merged 5 commits into
Elijah King (eli-w-king) merged 5 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 665ae24f-55b9-4b8f-89ac-8c51a1bf08e4
Elijah King (eli-w-king)
requested review from
Cherry Wang (chryw),
Lee Murray (mrleemurray) and
Raymond Zhao (rzhao271)
October 7, 2026 17:05
Contributor
Screenshot ChangesBase: Changed (7)
|
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CompactNeedsInput/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CompactNestedChatApprovals/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_NestedChatApprovals/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_NestedChatApprovals_Phone/Light
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/NeedsInput/Light
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/ApprovalRowLongLabel/Light
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The locked Codicon font package does not yet contain the newly registered ECF8 glyph.
1 open finding
What changed in this PR
Updates session attention indicators to use the new report-question Codicon consistently.
Changes:
- Replaces
reporticons across session UI surfaces. - Updates focused tests and visual descriptions.
- Registers the prerequisite Codicon.
| File | Description |
|---|---|
src/vs/base/common/codiconsLibrary.ts |
Registers the new icon. |
src/vs/sessions/services/sessions/browser/sessionsListModelService.ts |
Updates the session status icon. |
src/vs/sessions/services/sessions/test/browser/sessionsListModelService.test.ts |
Updates model expectations. |
src/vs/sessions/test/browser/sessionStatusIcon.test.ts |
Updates rendered-icon expectations. |
src/vs/sessions/contrib/sessions/test/browser/sessionsList.test.ts |
Updates list icon selectors. |
src/vs/sessions/contrib/sessions/test/browser/sessionsList.fixture.ts |
Updates visual descriptions. |
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsViewer.ts |
Updates workbench session icons. |
src/vs/workbench/contrib/chat/browser/agentSessions/experiments/agentTitleBarStatusWidget.ts |
Updates title-bar attention icons. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 665ae24f-55b9-4b8f-89ac-8c51a1bf08e4
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 665ae24f-55b9-4b8f-89ac-8c51a1bf08e4
Elijah King (eli-w-king)
force-pushed
the
eli/use-report-question-for-session-attention
branch
from
October 7, 2026 18:47
80d2730 to
b3fe336
Compare
Lee Murray (mrleemurray)
previously approved these changes
Oct 7, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 665ae24f-55b9-4b8f-89ac-8c51a1bf08e4
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Sandeep Somavarapu (@sandy081)Matched files:
Ladislau Szomoru (@lszomoru)Matched files:
|
Elijah King (eli-w-king)
enabled auto-merge
October 9, 2026 20:46
Elijah King (eli-w-king)
requested review from
Jessie Houghton (houghj16) and
Rohan Malpani (romalpani)
October 9, 2026 20:46
Cherry Wang (chryw)
approved these changes
Oct 9, 2026
Jessie Houghton (houghj16)
approved these changes
Oct 9, 2026
Elijah King (eli-w-king)
deleted the
eli/use-report-question-for-session-attention
branch
October 9, 2026 21:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reporticon withreport-questionwhen sessions need user attentionDependency
Depends on #340328 for the Codicon registration and
@vscode/codicons@0.0.46-44package update.Validation
npm run eslint -- <8 changed files>npm run build-fast -- --client-only./scripts/test.sh --grep 'report-question|matches sessions window state icons'— 5 passing