Skip to content

fix(xiaoyunque): support reference video assets#25

Merged
superche merged 3 commits into
mainfrom
feat/xiaoyunque-reference-video
Jul 22, 2026
Merged

fix(xiaoyunque): support reference video assets#25
superche merged 3 commits into
mainfrom
feat/xiaoyunque-reference-video

Conversation

@superche

Copy link
Copy Markdown
Contributor

Summary

  • register legacy upload_file reference-video results through AssetCreateV2 when pippit_asset_id is missing or blank
  • preserve the direct-ID path and existing image behavior while mapping the upload and registration asset enums correctly for video
  • add video-specific safe diagnostics and end-to-end fake-API coverage
  • release xiaoyunque-generation 0.3.5 with companion 0.3.3 and Registry sequence 24

Follow-up to #19.

Root cause

upload_file uses asset type 1 for video and may return only an EverPhoto asset_id. The generation payload also needs the registered Pippit identity. #19 registered upload type 2 (images), so reference video could reach submission without pippit_asset_id.

Impact

Reference videos uploaded from Convax are now registered before generation submission. Existing uploads that already return pippit_asset_id remain unchanged. Registration failures stop before submission and expose only stable safe diagnostics.

Validation

  • bun install --frozen-lockfile --ignore-scripts
  • focused XiaoYunque typecheck and 53 tests
  • bun run check (workspace builds/typechecks/tests, companion builds/smokes, tooling tests, validation, packing, and Registry/Showcase index generation)
  • 33 FFmpeg workspace tests, 112 XiaoYunque workspace tests, and 52 tooling tests passed

No live or billable XiaoYunque generation was triggered.

@superche
superche marked this pull request as ready for review July 22, 2026 13:42
@superche
superche merged commit 5769b2d into main Jul 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant