Conversation
cronRenewCert.php ran acme.sh --cron and then unconditionally called GetSslMain::run(). After an upgrade from the legacy getssl client, --cron silently no-ops (no renewal config exists yet), and run() picked up the leftover legacy cert from db/getssl/<domain>/ and reinstalled it into PbxSettings, logging "SSL certificate installed" while the cert was actually the same expired file. The bug went undetected until a real expiry hit production. - cronRenewCert.php: detect via hasAcmeDomain() whether acme.sh already has a renewal config; if not, call startGetCertSsl(false) for a full --issue. Drop the trailing run() call — acme.sh triggers reloadCmd.php (--reloadcmd) on success, which already invokes run(). - GetSslMain::run() / getCertPath() / getPrivateKeyPath(): remove the legacy-getssl fallback. After migration the source of truth is acme.sh's config home; falling back to legacy paths masked the bug above. ECDSA (_ecc) is checked first, RSA second, then '' is returned so run() reports "not found" instead of reinstalling stale files.
The afterSave hook in MikoPBX core fires a publish to nchan via HTTP; when triggered from acme.sh --reloadcmd it races with nginx reload and fails with cURL error 56. The DB write itself has already succeeded, so swallow the exception and log a short note instead of polluting last-result.log with a 31-line stack trace per key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.