Conversation
Import module source tree onto develop branch. Fix: use CallerIDNum instead of CallerIDName for conference participant lookup so join announcements (TTS) play correctly.
- Resolve participant number from channel name (transport-safe: handles PJSIP/<n>-, -WS-, -TLS-) instead of unreliable CallerID fields, fixing dedup and TTS announcements. - Use AGI(meetme_dial.php) instead of removed cdr_connector.php so ConfBridge CDR rows finalize correctly on this PBX version. - Add pending-invite guard (40s) to avoid re-dialing participants who are still ringing when the leader joins.
- Add .github/workflows/build.yml using mikopbx reusable extension-publish workflow (triggers on master/develop). - Add release_settings to module.json (publish + changelog + release). - Declare cesargb/php-log-rotation dependency (used by Lib/Logger) so composer install restores it during CI build; fix package name.
- Auto-dial participants through the module's own [internal-originate-selector-conf] context (clone of core [internal-originate] without the interception_start gosub): each participant enters the conference as a real PJSIP channel with one grouped MeetMe/ANSWERED CDR row and no ORIGINATE_TRY_DIAL noise, while keeping multi-registration contact resolution (set-dial-contacts). - Reload the dialplan on module enable/disable (onAfterModuleEnable/onAfterModuleDisable -> PbxConf::dialplanReload) so the custom context appears without a manual reload. - Add a per-rule enabledAlert toggle (default off) that gates the TTS join announcement; wired through model, form, view, controller and messages.
- INSTALL.md: canonical WorkerModuleInstaller command + settings.json; the module's dialplan context is raised on enable. - docs/translations-cache.md: the 3-layer translation cache tied to versionsHash and how to invalidate all layers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...