Repository navigation
[cherry-pick] fix: release BulkWriter locks in finally blocks (#2106) - #2107
Merged
Merged
Conversation
appendLock, fileWriteLock and workingThreadLock were released without try/finally. If the guarded code threw (IOException, OutOfMemoryError, a failed chunk upload in commitIfFileReady), the lock stayed held by the throwing thread, and every other thread calling appendRow parked forever. Fixes #2104 Signed-off-by: Waqqas Jabbar <waqqas@vectara.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit f1c0e03)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yhmo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks commit
f1c0e035e6710c77c5e9af8f536a05547e4e7119(f1c0e03) frommasterto3.0.Created automatically by the backport workflow after the PR was merged to master.
appendLock, fileWriteLock and workingThreadLock were released without
try/finally. If the guarded code threw (IOException, OutOfMemoryError,
a failed chunk upload in commitIfFileReady), the lock stayed held by
the throwing thread, and every other thread calling appendRow parked
forever.
Fixes #2104
Signed-off-by: Waqqas Jabbar waqqas@vectara.com
Co-authored-by: Claude Opus 5.5 noreply@anthropic.com