🐛 fix some uncaught exceptions preventing the creation of LocalInputSource#206
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes uncaught exceptions during LocalInputSource initialization so PDF inputs that FPDI can’t parse (e.g., unsupported compression) don’t prevent creating an input source, aligning with issue #205’s request to bypass local PDF handling failures.
Changes:
- Add a regression test asserting
pageCountbecomesnullwhen encountering an unsupported PDF (e.g.,XfaForm.pdf). - Broaden constructor exception handling to avoid failing
LocalInputSourcecreation when PDF parsing throws. - Minor formatting adjustment in
compress()signature.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/Input/LocalInputSource.php |
Adds a broad fallback catch during construction to avoid aborting on PDF-related exceptions; minor formatting change. |
tests/Input/LocalInputSourceTest.php |
Adds a test covering unsupported PDF parsing to ensure pageCount is null. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #205
Types of changes