Skip to content

The agent review check builds again: canon's lock file and the SDK it is built with #83

Open

Description

@Hafeok

Outcome. The agent review check builds and runs on a pull request again, and it does not break at the next .NET patch release.

Why now. The trunk rule on main requires two status checks: pipeline (devcontainer) and agent review. The agent review workflow fails at its build step, so no pull request can land. #80's pull request and PRs #73 and #74 all wait on this.

Ground. AGENTS.md. tools/canon/global.json, Directory.Build.props, Directory.Packages.props and src/Canon/packages.lock.json. .github/workflows/agent-review.yml and validate.yml. .devcontainer/devcontainer.json. core/decisions/DDD-dec-101.yaml and the decisions that rule canon's build.

What was observed, 2026-11-18.

Read from the files at 84aa466, by Claude, UNVERIFIED — Emil review.

  • global.json asks for SDK 10.0.100 with rollForward: latestFeature, so any newer 10.0 SDK is accepted.
  • Microsoft.NET.ILLink.Tasks is in the lock file as a direct dependency requested at [10.0.14, ). Nothing in the project files names it. The SDK adds it, at the version of the SDK in use.
  • Directory.Build.props turns locked mode on when CI is set. So a newer SDK than the one that wrote the lock file fails the restore.
  • The agent review workflow installs .NET with actions/setup-dotnet. The devcontainer installs it with the dotnet feature at version 10.0. Neither names a patch.
  • So validate passes only while the devcontainer still holds the older SDK. When it picks up the newer one, validate fails the same way.

Deliverable.

  1. The diagnosis confirmed or corrected: which SDK each workflow gets today, why the two differ, and where the dependency comes from. Exit: the session reproduces NU1004 and says in one sentence what causes it.

  2. Proposals, each with its weakest point and what it breaks. At least these two:

    • regenerate the lock file for the newer SDK and change nothing else;
    • pin the SDK to one exact version in global.json, have both the workflow and the devcontainer install that version, and regenerate the lock file once.

    Exit: each says what happens at the next .NET patch release.

  3. On the ruling, the fix. Exit: both required checks pass on this issue's own pull request: pipeline (devcontainer) and agent review. The validate workflow passes, and every commit carries a Refs line for this issue.

Gates. G1 after step 2: the principal rules which fix. G2 after step 3. Then the merge.

Out of scope. Any change to what canon checks. Any claim, decision text, method card or lifecycle data, beyond a decision record if the ruling needs one. The act map work (#80, #81, #82).

Opening position, [PROPOSED]: the second option. Regenerating alone fixes today and fails again at the next patch, and it fails validate as soon as the devcontainer is rebuilt.

A caution for the session: the agent review workflow runs from main (pull_request_target), so a change to the workflow file itself is not exercised by the pull request that makes it. Say how the fix is shown to work before it lands.

Corrections and rulings, 2026-11-18

Correction (Claude, found by this issue's session at its G1). The reading above is wrong on one point and silent on another.

  • validate does not pass because the devcontainer holds an older SDK. It holds the same one, 10.0.404. It passes because CI is never passed into the container, so the restore there is never locked. validate has never enforced canon's lock file.
  • The deadlock. The agent review job checks out main and builds main's canon, and the trunk rule requires agent review with an empty bypass list. So the check fails on every pull request, this issue's own included, until main builds. Deliverable 3's exit cannot be met as written.

Ruled by Emil at G1 ("agreed and accepted", 13:57), on the session's proposals and Claude's recommendation:

  • The fix is option B: pin the SDK exactly in global.json with rollForward set to disable, pin the same version in devcontainer.json, and regenerate the lock file once. agent-review.yml does not change. The version is 10.0.404.
  • CI is passed into the devcontainer, so validate restores in locked mode. This closes a gap in an existing rule (Directory.Build.props) and is not a new check.
  • Emil lifts the agent review requirement on the trunk rule for this one landing and restores it straight after. No standing bypass is added. The waiver is recorded as a decision, whose text Emil rules before it is filed.
  • A throwaway workflow on the session's branch is allowed, to show the build on a real runner: push to that branch only, read-only permissions, no secrets, removed before the head to ratify.
  • Deliverable 3's exit becomes: validate passes on the head with locked restore; the session's pre-landing proofs pass; every commit carries a Refs line. The first agent review run after landing is the final proof.

Successor items, not acted on here: a scheduled check that says when a newer .NET patch exists; and the deadlock itself, since a required check that builds main's canon with no bypass means a broken main can only be repaired by suspending the rule.


Generated by Claude Code

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    Priority

    None yet

    Effort

    None yet

    Progress

    None yet

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions