Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,12 @@

// The .NET SDK beside Python, for canon (tools/canon/, DDD-dec-101): built from source here and
// in CI, never pulled from a feed (DDD-dec-106). The feature's major version was checked against
// ghcr.io/devcontainers/features/dotnet on 2026-11-02 (latest 2.5.0).
// ghcr.io/devcontainers/features/dotnet on 2026-11-02 (latest 2.5.0). The SDK is the exact version
// tools/canon/global.json pins (rollForward "disable"); the two are bumped together, with the lock
// file (#83). A drift fails validate: dotnet refuses to run in tools/canon/ on any other SDK.
"features": {
"ghcr.io/devcontainers/features/github-cli:1": {},
"ghcr.io/devcontainers/features/dotnet:2": { "version": "10.0" }
"ghcr.io/devcontainers/features/dotnet:2": { "version": "10.0.404" }
},

"onCreateCommand": "pip install --no-cache-dir -r scripts/requirements.txt && dotnet build tools/canon/canon.slnx",
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,13 @@ jobs:
# Gate 2 it adds three checks no Python gate makes: its own tests, CHANGELOG.md as the
# projection of releases/ (DDD-dec-104), and Refs #N with Basis: on canon commits over
# the range under test (DDD-dec-105). GITHUB_BASE_REF is passed in so a pull request's
# range is base..head.
# range is base..head. CI is passed in so canon's restores are locked here as on any CI
# runner (tools/canon/Directory.Build.props): a lock file that does not match the pinned
# SDK fails this job, as it fails agent review (#83). The rule is not new; the container
# did not see CI, so it was not applied here.
env: |
GITHUB_BASE_REF
CI
runCmd: |
set -e
python3 scripts/ci.py
Expand Down
32 changes: 32 additions & 0 deletions meta/sessions/2026-11-18-canon-lock-file/bootstrap.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Bootstrap — canon's lock file, 2026-11-18

Filled in at arrival and committed with `prompt.md` as the session's first commit.

| Parameter | Value |
|---|---|
| Invocation | Interactive, gated. Emil's prompt is verbatim in `prompt.md` |
| Principal | Emil (rules the fix at G1; ratifies the head at G2) |
| Issue | [#83](https://github.com/mindovermachine-dev/decision-driven-design/issues/83). Every commit of the session carries `Refs #83` |
| Upstream pin | unchanged by this session (`graph/upstream.yaml`) |
| Downstream base | `84aa466` (`84aa4665b4b0392ef4bb08ac042e42ae9fc6d12c`), the head of `main` at arrival |
| Downstream branch | `claude/canon-lock-file-2026-11-18`, from `main` at `84aa466` |
| Local toolchain | `dotnet --list-sdks`: `10.0.404` only (this container; not the devcontainer) |
| Model | Claude Opus 5.5 |

## Gates

| Gate | What | Who |
|---|---|---|
| G0 | This charter committed before any other change | Claude |
| G1 | Deliverable 1 (NU1004 reproduced, diagnosis confirmed or corrected) and deliverable 2 (proposals, weakest point first, each with what happens at the next .NET patch) | Claude; **stops for Emil's ruling** |
| G2 | Deliverable 3, the ruled fix: a pull request against `main`, the head to ratify named, `pipeline (devcontainer)` and `agent review` reported for it | Claude; **stops for Emil** |

## Scope

In scope: `tools/canon/` build inputs (SDK selection, lock files) and, if ruled, the SDK install
in `.github/workflows/agent-review.yml`, `.github/workflows/validate.yml` and
`.devcontainer/devcontainer.json`; this session record and its row in `meta/sessions/README.md`;
a decision record only if the ruling needs one.

Out of scope: anything that changes what canon checks; any claim, decision text, method card or
lifecycle data; the branches of #80 and the archive branch; the act map work (#80, #81, #82).
51 changes: 51 additions & 0 deletions meta/sessions/2026-11-18-canon-lock-file/decision-draft.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
# DRAFT for Emil's ruling on its text (G1, Q-1). Not filed: it is not under core/decisions/ and
# no gate reads it. On the ruling, the id is settled (question at the foot), the <...> fields are
# filled with the head and the times Emil gives, and it is filed as core/decisions/<id>.yaml.
format: 1
id: DDD-dec-123
kind: decision
statement: |
For one landing only, the trunk ruleset's required `agent review` check is lifted, so that #83's fix can reach main; it is restored straight after. Nothing else in trunk or in any other ruleset changes, and nothing in DDD-dec-108 or DDD-dec-109 is superseded. The waiver is not a precedent: a later broken main is a new decision.
principal: Emil
made: |
2026-11-18, G1 of the canon-lock-file session (issue #83), given by Emil in the session and recorded verbatim at meta/sessions/2026-11-18-canon-lock-file/rulings.md (received 13:17 UTC). The requirement was lifted at <time lifted, Emil's> and restored at <time restored, Emil's>, both by Emil as repository admin. Emil's ruling on this record's text is the filing act
resolution: |
## The ruling

> Q-1. I will lift the "agent review" requirement on the trunk ruleset for this one landing and
> restore it straight after. You do not touch the ruleset.

## What was waived

The `required_status_checks` entry `agent review` (integration 5594102, the gates App) in the
trunk ruleset (.github/repo-standard.yaml), for the landing of head <head that landed> to main
and for nothing else. The trunk ruleset's other rules held throughout: `pipeline
(devcontainer)` required, deletion and non-fast-forward refused. Signed Commits was not
touched.

## Why no other path existed

- The `agent review` verdict is a check run posted by the gates App ("mom-gates", integration
5594102), and the ruleset requires that name from that App (DDD-dec-109). No job a pull
request can change may post it, by design.
- The agent review job checks out main by name and builds main's canon before it judges
(.github/workflows/agent-review.yml, "Checkout main"). Main's canon did not build on the
runner's SDK: NU1004, the lock file at Microsoft.NET.ILLink.Tasks 10.0.14, the runner's SDK
10.0.404 adding 10.0.15 (meta/sessions/2026-11-18-canon-lock-file/findings.md, D-1 to D-4).
- So agent review failed on every pull request whatever it held, the fix's own included, and
trunk has no bypass actor, the admin role included (DDD-dec-108). The fix could reach main
only if the requirement was suspended.

## What showed the fix before it landed

Validate on the head, with locked restore (CI passed into the devcontainer); the agent review
job's build on a clean install of SDK 10.0.404 with CI set; the same on a GitHub runner by a
throwaway workflow, removed before the head (findings.md, deliverable 3). The first agent review
run after the landing is the final proof: <run, filled after the landing>.
basedOn:
- DDD-dec-108
- DDD-dec-109
notes: |
Successor, recorded by Emil's ruling and not acted on: a required check that builds main's
canon, with no bypass, means a broken main can only be repaired by suspending the rule. This
record is the first time that happened.
Loading
Loading