Skip to content

Compatibility with Seasonal Horizons - #16

Merged
mist475 merged 1 commit into
mist475:masterfrom
DarkShadow44:seasons
Sep 30, 2026
Merged

mist475 merged 1 commit into
mist475:masterfrom
DarkShadow44:seasons

Conversation

@DarkShadow44

Copy link
Copy Markdown

My new season mod Seasonal Horizons changes the temperature in winter. This leads to snow where vanilla would render rain.

This PR adds compatibility by using the season API to check biome temperature.

@mist475

mist475 commented Sep 28, 2026

Copy link
Copy Markdown
Owner

Once I'm back from vacation later this week I'll take a look in-game. Is there a reason someone might want to disable the compat? If so I'll add it to the config.
Code wise, is this something OptionalInterface could be used for? I vaguely remember it existing for things like this but I've never used it

@DarkShadow44

Copy link
Copy Markdown
Author

Once I'm back from vacation later this week I'll take a look in-game. Is there a reason someone might want to disable the compat? If so I'll add it to the config. Code wise, is this something OptionalInterface could be used for? I vaguely remember it existing for things like this but I've never used it

I don't see why someone would want to disable compat - that would make rain/snow render wrong and cause other issues like this. If they want seasons, all mods should treat winter like winter.

The optional annotations are a thing, but I don't think they are useful here. They're useful if you implement a mod's interface and want to strip that out if the mod is not loaded.

@mist475
mist475 merged commit 94ff718 into mist475:master Sep 30, 2026
@DarkShadow44
DarkShadow44 deleted the seasons branch September 30, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants