Add CUDA 13 runtime headers - #3930
Draft
jasp-nerd wants to merge 1 commit into
Draft
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #3859.
The CUDA 13 backend wheel does not depend on the package containing
cuda_runtime.h. After that package is installed, its CUDA 13 headers areunder
nvidia/cu13/include, while MLX only checks the CUDA 12nvidia/cuda_runtime/includelayout.This change:
existing toolkit fallback;
The path tests use isolated package trees so a system CUDA installation cannot
mask a missing package lookup. CCCL is not added because MLX already bundles
the CCCL headers used by its JIT kernels.
Validation:
This machine does not have a CUDA toolkit or NVIDIA GPU, so the real CUDA 13
wheel build, JIT smoke test, and Windows coverage are left to repository CI.
I used an AI coding assistant to help research and prepare this change; I
remain responsible for the submitted patch.
Checklist
pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes