Brief refactoring in response to Copilot/Claude code review - #83
Open
rshiggin wants to merge 1 commit into
Open
Conversation
rshiggin
marked this pull request as ready for review
August 25, 2026 20:45
ssciolla
approved these changes
Aug 25, 2026
ssciolla
left a comment
ssciolla
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Mildly suggesting that we use a more specific error type.
Comment on lines
+72
to
+76
| raise "REPOSITORY_ID is not set; cannot index repository fields" if slug.blank? | ||
| repository = Arclight::Repository.find_by(slug: slug) | ||
| if repository.nil? | ||
| raise "No repository found for slug #{slug.inspect} — check REPOSITORY_ID " \ | ||
| "against the slugs defined in config/repositories.yml" |
Collaborator
There was a problem hiding this comment.
We could define a custom error type like TrajectEADIndexError and raise that specifically. What we're doing now will result in RuntimeErrors I think. E.g.
class TrajectEADIndexError < RuntimeError
end
# in your code
raise TrajectEADIndexError, "REPOSITORY_ID is not set..." if slug.blank?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supplements branch
arc-170-repo-id-requestable-bug, PR https://github.com/mlibrary/boxwalker/pull/79[https://github.com/mlibrary/boxwalker/pull/79](url)