Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/mcp/server/validation.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,5 +84,7 @@ def validate_tool_use_result_messages(messages: list[SamplingMessage]) -> None:
if has_previous_tool_use and previous_content:
tool_use_ids = {c.id for c in previous_content if c.type == "tool_use"}
tool_result_ids = {c.tool_use_id for c in last_content if c.type == "tool_result"}
if not has_tool_results:
raise ValueError("tool_use blocks must be followed by matching tool_result blocks")
if tool_use_ids != tool_result_ids:
raise ValueError("ids of tool_result blocks and tool_use blocks from previous message do not match")
17 changes: 17 additions & 0 deletions tests/server/test_validation.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,23 @@ def test_validate_tool_use_result_messages_raises_when_tool_result_ids_dont_matc
validate_tool_use_result_messages(messages)


def test_validate_tool_use_result_messages_raises_when_tool_use_has_no_following_tool_result() -> None:
"""Raises a specific error when the previous assistant tool_use has no following tool_result."""
messages = [
SamplingMessage(
role="assistant",
content=ToolUseContent(type="tool_use", id="tool-1", name="test", input={}),
),
SamplingMessage(
role="user",
content=TextContent(type="text", text="No tool result is provided"),
),
]
with pytest.raises(ValueError) as exc_info:
validate_tool_use_result_messages(messages)
assert str(exc_info.value) == "tool_use blocks must be followed by matching tool_result blocks"


def test_validate_tool_use_result_messages_no_error_when_tool_result_matches_tool_use() -> None:
"""No error when tool_result IDs match tool_use IDs."""
messages = [
Expand Down
Loading