Repository navigation
S2: RocketWelder.SDK.Robotics.Core deleted (epic-129, FR-10) - #32
Merged
Merged
Conversation
The package was a further forward-kinematics implementation (FK, IK, CollisionDetector, SimulatedRobot, RobotPresets, Matrix4x4d, DhJoint, FkValidator) with no consumer in rw2, simulator, mcp, universal-robotics or fairino. It is deleted, not moved: platform kinematics belong in Drawing/Matrix. - csharp/RocketWelder.SDK.Robotics.Core/ and .Tests/ removed - both projects and their configuration rows removed from RocketWelder.SDK.sln (the publish workflows pack the sln, so the package is no longer packed) - the test project removed from .github/workflows/test.yml No other package changes; no version bump. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014wH5aL3TZhJNvLqa8YTku8
rafalmaciag
commented
Oct 24, 2026
rafalmaciag
left a comment
Contributor
Author
There was a problem hiding this comment.
Independent review of 6557761 (epic-129 S2): APPROVE. GitHub refuses a formal approval because this account opened the PR, so the review is posted as a comment.
- The deletion is complete. Both folders are gone, along with both sln
Projectentries and their 24 configuration rows.test.ymlno longer lists the test project, and its comment is updated. G-8 finds 0 lines and G-9 finds 0 lines. No README, docs, release script orDirectory.Build.*names the package. The only remaining mentions are thetest.ymlcomment and the historicalDevices.Motion/dev-log.md:190. - The change is only a deletion. Outside the two folders, the diff touches only
csharp/RocketWelder.SDK.slnand.github/workflows/test.yml. There is no version bump and no publishing change. - Tests, run natively in Release with .NET 10.0.401. Both master 1d23ae9 and the branch build with 0 errors. The test counts match the ledger: AdaptivePoints 14, Automation 109, Devices.Motion 67, Devices.Robot 19, Devices.Welding 47, Http 155, Operations.Welding 41 and Types 56 passed, with 0 failed and 0 skipped on both commits. Robotics.Core.Tests had 247 passing on master. Server.Tests shows the same 2 failures on both commits (Python venv,
/tmp/zerobuffer/lockspermission denied). SDK.Tests shows the same 4SegmentationResultTests.CrossPlatform_*failures on both commits. On master, only Robotics.Core.Tests referenced Robotics.Core, so none of these failures relate to the deleted code. - No consumer. In the csproj, sln, props and targets files of rocket-welder2 @307b2fdd, simulator @7c75764 and mcp @36772d3d there is no reference. The only hit is the prose
<Description>ofModelingEvolution.Robot.Abb.Simulator.csproj. - CI. Both "C# tests" runs pass, and so does
preview-version.publish-csharp-previewpacked 21 .nupkg files, none of them Robotics.Core. It then failed on403 (The specified API key is invalid, has expired...), which is the nuget.org key and not the pack.
Minor corrections to the PR body; nothing in the code changes.
- CI runs 7 suites, not 8.
RocketWelder.SDK.Http.Testsis not intest.ymlon master or on this branch. That gap was there before this PR and should be followed up separately. - On this host,
SDK.Testshung after the 4 failures on master and on the branch alike, so I could not reproduce the "329 passed" total. The test run was stopped by my 900 s timeout. The suite is not in CI.
🤖 Generated with Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epic-129 slice S2 (FR-10 b, c; TS-129-47; grep rows G-8/G-9).
RocketWelder.SDK.Robotics.Corewas another forward-kinematics implementation (FK, IK,CollisionDetector,SimulatedRobot,RobotPresets,Matrix4x4d,DhJoint,FkValidator), and nothing used it. It is deleted, not moved anywhere. No other package changes, no version bump and no release.Deleted
csharp/RocketWelder.SDK.Robotics.Core/andcsharp/RocketWelder.SDK.Robotics.Core.Tests/(45 files, about 5,450 lines)csharp/RocketWelder.SDK.sln: bothProjectentries and their 24 configuration rows. Neither project was inNestedProjects..github/workflows/test.yml: theRocketWelder.SDK.Robotics.Core.Testsline in the test list, and the matching comment updated.publish-csharp-nuget.ymlandpreview-publish.ymlpackRocketWelder.SDK.sln, so taking the project out of the sln stops it being packed. I checked with a localdotnet pack RocketWelder.SDK.sln --no-build: it produces 21 packages and none isRobotics.Core.release.sh,csharp/release.sh, READMEs, docs andDirectory.Build.*did not mention the package, so they are unchanged.csharp/RocketWelder.SDK.Devices.Motion/dev-log.md:190.Greps (on the branch)
Before the deletion, G-8 found no hits outside Robotics.Core, so there was no second kinematics implementation to deal with.
Test ledger (native, .NET SDK 10.0.401,
-c Release, every test project in the sln)All 8 suites that CI runs pass, with failed = 0 and skipped = 0. The 6 failures in the two suites CI does not run are the same tests on master and on the branch. They come from the host, not this change: four
SegmentationResultTests.CrossPlatform_*tests andServerIntegrationTests.Server_And_Client_CanCommunicate_ViaSharedMemoryhitPermission deniedon/tmp/rocket-welder-testand/tmp/zerobuffer/locks, which another user owns on this shared host;BallDetectorE2ETestsfails with "Python venv not found".test.ymlalready leaves these two suites out because they need native shared-memory infrastructure.Cross-repo check (TS-129-47)
<Description>ofModelingEvolution.Robot.Abb.Simulator.csproj("no SDK Robotics.Core dependency") and an XML doc comment inKinematics/Mat4.cs.🤖 Generated with Claude Code
https://claude.ai/code/session_014wH5aL3TZhJNvLqa8YTku8