refactor(body_cap): share non-iteration logic between sync/async#102
Merged
Conversation
Extract declared-length validation and response reconstruction into _reject_if_declared_length_exceeds_cap and _build_buffered_response, eliminating duplication between _read_capped and _read_capped_async. The byte-accumulation loops remain separate (sync vs async). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_read_capped/_read_capped_asyncin_internal/body_cap.pyinto shared functions:_reject_if_declared_length_exceeds_cap(declared-Content-Length early-reject) and_build_buffered_response(final Response reconstruction).client.pybut didn't fully share at the time.Fix folded in from final review: no test anywhere asserted
content_lengthon thereason="streamed"path when a declared length is actually present (the gzip-bomb scenario) — every existing "streamed" test used a chunked body with no declared length. A dropped return value across the new function boundary would have shipped green at 100% coverage. Added the missing assertion plus a new async mirror test (also closing a pre-existing sync/async parity gap — there was no async gzip-bomb test at all before this).Change file (Lightweight lane):
planning/changes/2026-07-13.06-body-cap-shared-non-iteration-logic.mdTest plan
just test— 780 passed, 100% coveragejust lint-ci— ruff format/check,ty check, planning validator all clean