fix(mflistfile): parse budget values missing the exponent "E" - #2858
Merged
wpbonelli merged 2 commits intoSep 29, 2026
Merged
Conversation
Fortran E/ES edit descriptors without an exponent width drop the "E" for three-digit exponents (e.g. 8.5159-100). MF6 list files can contain such values, which caused ListBudget to fail parsing the budget. Accept these values when parsing budget lines. Close modflowpy#2855 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The parametrized _parse_budget_line test covers the fix, and float32 budget arrays prevent the end-to-end test from checking parsed values. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2858 +/- ##
===========================================
+ Coverage 55.5% 73.7% +18.2%
===========================================
Files 644 659 +15
Lines 124135 132398 +8263
===========================================
+ Hits 68947 97696 +28749
+ Misses 55188 34702 -20486
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MF6 list files can contain values with three-digit exponents written without the "E", a Fortran quirk for E/ES formats without an explicit exponent width. This caused
ListBudgetparsing to fail. Tolerate this when parsing budget lines. MF6 will be fixed too, but list files from existing versions will still contain these values.Close #2855