fix(labrinth): fix filtering not working unless breakdown set to same field#6608
Open
penguinencounter wants to merge 2 commits into
Open
fix(labrinth): fix filtering not working unless breakdown set to same field#6608penguinencounter wants to merge 2 commits into
penguinencounter wants to merge 2 commits into
Conversation
Member
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
penguinencounter
force-pushed
the
fix-analytics-filters
branch
9 times, most recently
from
ee71433 to
7690607
Compare
penguinencounter
changed the title
penguinencounter
force-pushed
the
fix-analytics-filters
branch
7 times, most recently
from
7e6fc2a to
914f090
Compare
Author
|
would appreciate it if someone could look at this |
penguinencounter
force-pushed
the
fix-analytics-filters
branch
from
914f090 to
3f3f6e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6607 plus some similar cases
a few notes:
|| !metrics.filter_by.<COLUMN>.is_empty()addedcargo sqlx preparedeleted a bunch of files. we've put that into its own commit so it can be dropped withgit reset --hardorgit rebase -irelatively easily if it's not meant to be thereand a screenshot of it doing the right thing:
