refactor: introduce PageHeader component#6629
Open
IMB11 wants to merge 12 commits into
Open
Conversation
Member
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
Member
Frontend previewsLast deployed commit is 505e6109fc22a21b477d84fc979ca8781ed13479
|
Prospector
requested changes
Jul 6, 2026
| const resolvedTooltip = computed(() => props.tooltip ?? (absoluteDate.value || undefined)) | ||
| const displayLabel = computed(() => [props.label, formattedDate.value].filter(Boolean).join(' ')) | ||
|
|
||
| function formatRelativeDate(date: Date, locale?: string) { |
Member
There was a problem hiding this comment.
this feels like it should be a global function and not specific to this component. we def already have one no?
| defineProps<{ | ||
| project: HeaderProject | ||
| projectV3?: HeaderProjectV3 | null | ||
| isServerProject?: boolean |
Member
There was a problem hiding this comment.
why's this not just calculated from projectV3?
| :value="project.downloads" | ||
| :label="formatMessage(messages.downloadsStat, { count: project.downloads })" | ||
| :tooltip="formatNumber(project.downloads)" | ||
| class="cursor-help" |
Member
There was a problem hiding this comment.
i regret adding the cursor-help thing, we should remove and not use that in places like this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.