Repository navigation
セッションのgc_maxlifetimeをCookie寿命に合わせる - #482
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QU4RwZicBuKve9wgiB3KHH
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e6c6fb2a68
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QU4RwZicBuKve9wgiB3KHH
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
初期化前にセッションを開始する経路ではGC寿命が既定値のままになるため。
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
管理画面セッションのGC寿命をCookie寿命へ合わせる変更。
session.gc_maxlifetimeを30日へ設定
| File | Description |
|---|---|
manager/includes/initialize.functions.inc.php |
セッションGC寿命をCookie寿命に同期 |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
管理画面で意図せずログアウトされる問題への対策です。Cookieの寿命は30日ですが、サーバー側の
session.gc_maxlifetimeが未設定のため、PHP既定値（約24分）でセッションがGCされる場合があります。これまではkeepaliveが延命していたため目立ちませんでした。変更内容
init::session_set_cookie_params()で、Cookieのlifetimeと同じ値をsession.gc_maxlifetimeに設定確認手順
備考
🤖 Generated with Claude Code
https://claude.ai/code/session_01QU4RwZicBuKve9wgiB3KHH
Generated by Claude Code