Repository navigation
Conversation
The submodule points at the fork, because the pinned commit is not upstream yet.
The pin forces this regen. The proxy walks notification metadata so a codec reaches it, and it sets the resource id header on the five channel requests.
1 of 3 tasks
Owner
Author
|
Paused per the 2026-10-05 design review (the decision record is on the proposal page, section 14). Resumes in phase 2 with the CHASM notification work. The branch stays as a pin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR regenerates the Go code for the notification channel service.
What changed?
proto/apipoints at the channel service commit on themoetemp/apifork, so.gitmodulesnames the fork until the api change lands upstream.notification/v1package, the five RPCs in the gRPC, gateway, proxy and mock code, andtemporalproto/openapi.proxy/request_header.gosetstemporal-resource-idtochannel:<name>on the five requests.proxy/interceptor.gowalksNotification.metadata, so a codec reaches it on notify, poll and describe.Part of AI-198 (epic AI-37).
Why?
It's the Go half of the channel service api PR. Nothing here is hand-written.
How did you test it?
Link to a test plan if any -
I ran the
make protogenerator targets. A regen at the upstream api commit reproducesmainwith no diff, so the plugin versions match.nexus-rpc-genisn't installed locally, but the Nexus inputs don't change, so the committed file stays.make check,go build ./...andgo test -tags protolegacy ./...pass.go vetpasses everywhere exceptinternal/protojson, which fails the same way onmain.