Skip to content

Regenerated for the notification channel service. - #2

Closed
moetemp wants to merge 2 commits into
mainfrom
moe/AI-198-ch-apigo-1-channel-service
Closed

moetemp wants to merge 2 commits into
mainfrom
moe/AI-198-ch-apigo-1-channel-service

Conversation

@moetemp

@moetemp moetemp commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner

This PR regenerates the Go code for the notification channel service.

What changed?

  • proto/api points at the channel service commit on the moetemp/api fork, so .gitmodules names the fork until the api change lands upstream.
  • Everything else is what the pin forces: the new notification/v1 package, the five RPCs in the gRPC, gateway, proxy and mock code, and temporalproto/openapi.
  • proxy/request_header.go sets temporal-resource-id to channel:<name> on the five requests.
  • The payload visitor in proxy/interceptor.go walks Notification.metadata, so a codec reaches it on notify, poll and describe.

Part of AI-198 (epic AI-37).

Why?

It's the Go half of the channel service api PR. Nothing here is hand-written.

How did you test it?

Link to a test plan if any -

  • Unit Tests
  • Staging
  • End to End Tests

I ran the make proto generator targets. A regen at the upstream api commit reproduces main with no diff, so the plugin versions match. nexus-rpc-gen isn't installed locally, but the Nexus inputs don't change, so the committed file stays. make check, go build ./... and go test -tags protolegacy ./... pass. go vet passes everywhere except internal/protojson, which fails the same way on main.

The submodule points at the fork, because the pinned commit is not upstream
yet.
The pin forces this regen. The proxy walks notification metadata so a codec
reaches it, and it sets the resource id header on the five channel requests.
@moetemp

moetemp commented Oct 6, 2026

Copy link
Copy Markdown
Owner Author

Paused per the 2026-10-05 design review (the decision record is on the proposal page, section 14). Resumes in phase 2 with the CHASM notification work. The branch stays as a pin.

@moetemp moetemp closed this Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant