Repository navigation
Conversation
The pinned commit adds the channel commands, events and describe field on top of the channel service.
The pin forces this regen. The proxy walks the held notification on `ChannelSubscriptionInfo` and the notifications on the scheduled event.
1 of 3 tasks
Owner
Author
|
Paused per the 2026-10-05 design review (the decision record is on the proposal page, section 14). Resumes in phase 2 with the CHASM notification work. The branch stays as a pin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR regenerates the Go code for the workflow listener of a notification channel.
What changed?
proto/apimoves to the workflow listener commit on themoetemp/apifork.notificationson the scheduled event,channel_subscriptionson describe, the enum values, andtemporalproto/openapi.WorkflowTaskScheduledEventAttributesand the held one onChannelSubscriptionInfo, so a codec reaches their metadata in History and on describe.Part of AI-198 (epic AI-37).
Why?
It's the Go half of the workflow listener api PR, and it's the module version the server pins. Nothing here is hand-written.
How did you test it?
Link to a test plan if any -
Same generator run as the previous PR.
make check,go build ./...andgo test -tags protolegacy ./...pass. The interceptor test needs no payload-count change because the channel commands carry no payload.go vetpasses everywhere exceptinternal/protojson, which fails the same way onmain.