Repository navigation
Conversation
The pinned commit adds the envelope a stream provider writes and reads.
The pin forces this regen. The proxy learns to walk a record's body and metadata, ready for the messages that will carry one.
1 of 3 tasks
Owner
Author
|
Replaced by #6 in the v5 series (phase 1, Signal wake only). The branch stays as a pin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR regenerates the Go code for the stream record envelope.
What changed?
proto/apimoves to the record envelope commit on themoetemp/apifork.stream/v1package withStreamRecordandStreamRecordKind.proxy/interceptor.gogets aStreamRecordcase forbodyandmetadata. Nothing reaches it yet, so no visitor count moves.Part of AI-198 (epic AI-37).
Why?
It's the Go half of the envelope api PR. Go code that reads or writes stream records through a provider needs the type. Nothing here is hand-written.
How did you test it?
Link to a test plan if any -
Same generator run and plugin versions as the channel PRs.
make check,go build ./...andgo test -tags protolegacy ./...pass.go vetpasses everywhere exceptinternal/protojson, which fails the same way onmain.