Repository navigation
Conversation
The pinned commit adds the stream commands, events, slices and ranges.
The pin forces this regen. The append command carries records, so the payload counts in the interceptor test grow with the visitor's new sites.
1 of 3 tasks
Owner
Author
|
Paused per the 2026-10-05 design review (the decision record is on the proposal page, section 14). Resumes in phase 2 with the CHASM notification work. The branch stays as a pin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR regenerates the Go code for native server streams.
What changed?
proto/apimoves to the native stream commit on themoetemp/apifork.StreamSlice,StreamRangeandStreamStartPosition, the two stream commands and events,stream_sliceson the poll response,consumed_stream_rangeson the completed event, the enum values, andtemporalproto/openapi.AppendStreamRecordsCommandAttributes.recordsandPollWorkflowTaskQueueResponse.stream_slices, so a codec sees record bodies and metadata both ways.proxy/interceptor_test.gois the one hand edit. Each record on the append command adds two payload sites, itsbodyand itsmetadatavalues, so the expected counts forCommandandRespondWorkflowTaskCompletedRequestgo up by two.Part of AI-198 (epic AI-37).
Why?
It's the Go half of the native stream api PR, and it's the module version the server's stream PRs pin. The test edit is there because the visitor walks new payloads, and that's the point.
How did you test it?
Link to a test plan if any -
Same generator run and plugin versions as the channel PRs.
make check,go build ./...andgo test -tags protolegacy ./...pass, the visitor test included.go vetpasses everywhere exceptinternal/protojson, which fails the same way onmain.