Repository navigation
Conversation
The workflow thread cannot see where the store's tail is, so the transport records the request, the Worker resolves it against the store after the task that opened the subscription, and the marker records the boundary so replay reads it from History.
…rds. stream_reader(after=END) and stream_reader(last=N) on the Redis provider now ask the transport for a tail start instead of being refused.
A reader at the newest N records and one at END each start where the live run resolved, and replay starts there too.
2 of 3 tasks
…198-s1-py-20-redis-start-positions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lets a workflow reader on the Redis provider start at the tail or at the newest N records.
What changed?
The transport gains
StartAtTail,subscribe(start_at_tail=), atail_cursor()hook on the backend, andresolve_pending_starts(), which the Worker calls before a completion goes out.RedisStreamsanswersstream_reader(after=END)andstream_reader(last=N)through that path instead of refusing. Replay cases cover both starts.Part of AI-198 (epic AI-37).
Why?
The workflow thread can't ask the store where its tail is. So the transport records the request, and the Worker resolves it against the store after the task that opened the subscription. The marker records the boundary beside the subscription, so replay and a cold start read it from History and never ask the store again.
How did you test it?
Link to a test plan if any -
The lint set is clean. The external stream suite and
tests/streamspass on the dev server the fixtures start.tests/streamswithSTREAMS_LIVE=redispasses against a stock dev server and a local Redis, including a reader at the newest N and one atEND, each replayed.