Repository navigation
Conversation
A completion the server rejects leaves the batch it staged under a token no marker will name. When History already says the task failed, the Worker aborts that stage at eviction instead of leaving it for a reader to find. A stage History committed stays pending for the client's repair.
A batch staged for a rejected task leaves the shared log once the Worker evicts the run, so an outside reader never meets it.
2 of 3 tasks
…AI-198-s1-py-22-eviction-settle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aborts a rejected task's staged output when the Worker evicts its run.
What changed?
On eviction the Worker asks History about each stage the run left pending. A stage whose task History failed or timed out is aborted. A stage History committed stays pending for the client's repair, as before. A Redis replay case shows a batch staged for a rejected task leaving the shared log once the run is evicted.
Part of AI-198 (epic AI-37).
Why?
A completion the server rejects leaves its batch under a token no marker will ever name. Before this, nothing settled it until a reader hit the barrier. On a provider whose workflow and producers share one log, those entries count against every window. This change is worker code, but its only test needs the Redis provider's shared log, so it sits after the Redis PRs.
How did you test it?
Link to a test plan if any -
The lint set is clean. The external stream suite and
tests/streamspass on the dev server the fixtures start.tests/streamswithSTREAMS_LIVE=redispasses against a stock dev server and a local Redis. The Nexus lanes, the workflow suite and the rest of the worker, client, Nexus and Workflow Streams suites pass too.