Repository navigation
Conversation
A query task commits only its answer, so the record could only be dropped later without a word. Raising ReadOnlyContextError says so at the call.
…if-py-11-query-publish-refusal.
1 of 3 tasks
Owner
Author
|
Replaced by #99 in the v5 series (phase 1, Signal wake only). The branch stays as a pin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
StreamWriter.publishraiseReadOnlyContextErrorwhen it's called from a query handler or an update validator.What changed?
StreamWriter.publishchecksworkflow_is_read_only()before handing the record to the provider, and raises the same error other read-only violations raise.Part of AI-198 (epic AI-37).
Why?
A query task commits only its answer. A record published there could only be dropped later, without a word. It's better to fail at the call, where the mistake is. It lands in the interface, so every provider above it, Max's External Workflow Streams (Option 7) and native alike, refuses the same way.
How did you test it?
Link to a test plan if any -
poe lintis clean. The workflow stream cases pass on the memory provider against the dev server the fixtures start, the new query case included.