Repository navigation
Conversation
This was referenced Oct 5, 2026
Owner
Author
|
Replaced by #100 in the v5 series (phase 1, Signal wake only). The branch stays as a pin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pins the Option 7 Core, Max's External Workflow Streams prototype in Core, and regenerates the bridge protos from it.
What changed?
temporalio/bridge/sdk-corepoints at the top of the Option 7 Core chain, the channel wake in moetemp/sdk-rust#32.poe gen-protosfrom that pin adds Max'sexternal_streampackage to the bridge protos, his external stream jobs and commands in the activation and command protos, theexternal_dataadditions, and theWorkflowStreamChannelscommand the channel wake reports with. Nothing undertemporalio/apichanges, since the channel api and the envelope are pinned lower in the chain.Three
### Fixedchangelog lines describe the Core fixes this pin brings: a wake met during cold replay resumes the waits, a stale wait no longer forces an output replacement task, and a retained task stays alive with the cache off.The pin moved once after it was first pushed, to the Core head that adds the reconciled channel tests. That change is test-only on the Rust side, so no generated file moved.
Part of AI-198 (epic AI-37).
Why?
Max's Python commits in the next PR expect his Core. Pinning first, with the regen, settles the gitlink and every generated file before the import. His commits that only moved the pin or regenerated protos then drop out as empty, and the import shows his hand-written code. One pin covers the whole Option 7 Core, wake included, since the Rust chain is finished before the Python side starts.
How did you test it?
Link to a test plan if any -
The bridge builds, the lint set is clean (ruff, pyright, mypy, basedpyright, pydocstyle and the bridge's clippy), and a second
poe gen-protosleaves the tree as committed.tests/streams, the replayer, worker and activity suites pass on the dev server the fixtures start.tests/streamsalso passes with-Eagainst a local server built from the channel server PRs.