Repository navigation
Conversation
The external stream interface writes `StreamRecord` as its record format, so lang code generated from these protos can import it. Nothing in the workflow service refers to it yet, so it is compiled as its own root.
This was referenced Oct 3, 2026
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR vendors the stream record envelope into Max's external-stream Core.
What changed?
temporal/api/stream/v1/message.protocomes in as it is in the record envelope api PR (Added the stream record envelope proto. api#4):StreamRecordandStreamRecordKind, nothing else.streampackage gets the serde derive and apub mod.Part of AI-198 (epic AI-37).
Why?
The external interface in the Python SDK writes
StreamRecordas its record format. Python generates its protos from Core's vendored tree, so the envelope has to be there first. The rest of the stream api doesn't belong to the interface and stays out of this lineage until the unified Core. The payload-limit entries forStreamRecordcome with that, because the check only counts fields a service message reaches.How did you test it?
Link to a test plan if any -
The workspace builds, the generated
temporal.api.stream.v1module has both types, the lints and fmt are clean, and the Core and common lib suites pass.