Repository navigation
Conversation
The reporter panics on any machine name it has no visualizer for, so every state machine has to be listed there.
`clippy::type_complexity` rejects the inline nested type, and the lint is denied through `-D warnings` in `cargo test-lint`.
Pages carry the same command list in order, only the intermediate ones are buffered, and the final page merges them, so the completion still reaches History as one commit.
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings the Core suite back to green on top of Max's import.
What changed?
ExternalStreamMachineis registered with the transition coverage reporter, afterNexusOperationMachine. The flush-window record in an external stream test becomes a type alias, socargo test-lintpasses.managed_run.rsgets four comment lines under Max's marker ordering rule. Upstream's completion pagination landed after his branch forked. It spreads the same command list across pages in order, the server buffers only the intermediate pages, and the final page merges them, so History still sees one commit with the marker where Max put it.The old suite-health PR had more chores, but they came out empty here. Upstream
mainalready carries the Nexus request-timeout fix and the integ fixes, #37 has the per-runner timeout, and the vendored WIT files already match upstream.Part of AI-198 (epic AI-37).
Why?
Every PR above this one needs a green suite to stand on. These changes land here, not inside the import, so #39 stays a pure replay of Max's commits. The pagination note belongs with them: it says why his rule still holds on a
mainhe never built against.The earlier version of this PR also brought two channel machine test files and a channel retry case. The notification channel is paused per the 2026-10-05 design review, so those tests come back with it in phase 2.
How did you test it?
Link to a test plan if any -
cargo fmt --check,cargo lint,cargo test-lint, the workspace lib suite, the Core lib suite with--include-ignored(so the coverage reporter runs) and the CIcargo doccheck all pass. The integ suites weren't run, since they need a server.