Repository navigation
Conversation
Core decodes the channel commands, events and RPCs only when its vendored api carries them. The type maps in the protos crate name the two new commands and events, which are not ignorable.
Notifications reach lang as their own job so a workflow can tell them apart from signals. The Rust SDKs have no channel API yet, so they ignore the job.
Language SDKs call the channel service through these entries, and a generated RPC table that names them does not compile without them.
This was referenced Oct 3, 2026
Owner
Author
|
Reopened as #25 to keep the numbers in review order. Same branch and content. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings the notification channel api into Core and exposes the channel RPCs to language SDKs.
What changed?
temporal.api.notification.v1, the five channel RPCs and their messages, the subscribe and unsubscribe commands and events,notificationson the Workflow Task scheduled event, andchannel_subscriptionson describe.NotificationsReceivedis a new activation job. The Rust SDK and the Rust workflow runtime have no channel API yet, so they ignore it.notify_channel,register_channel_listener,unregister_channel_listener,poll_channelanddescribe_channelare on the Core client and in the C bridge dispatch.notificationpackage.Notification.metadataisn't validated against the blob limit, since the server bounds it with its own notification size limit.Part of AI-198 (epic AI-37).
Why?
Language SDKs reach the server through Core, so a channel API in Python needs these RPCs on the Core client first. The generated Python RPC table doesn't compile without them. The job has to exist before Core can deliver notifications, and that comes in the next PR together with the commands and their machines. This PR has no commands, so it can't send anything Core can't handle yet.
How did you test it?
Link to a test plan if any -
The workspace builds,
cargo lint,cargo test-lintandcargo fmt --checkare clean, and every commit builds on its own. The protos, common, client, SDK and workflow crates' unit tests pass. The vendored files are byte-identical to the api PR.