Repository navigation
Conversation
The pin adds five WorkflowService RPCs, so the generated clients, interceptors and mock follow, and the frontend answers the RPCs with Unimplemented until the channel service serves them.
Every WorkflowService method needs a row in these tables, and the tests that walk the service fail on a method without one. Channel writes are treated like a Signal and the long poll like the other polls.
An event a command writes is never buffered, and the buffer test walks every event type the pinned API declares.
This was referenced Oct 3, 2026
Owner
Author
|
Paused per the 2026-10-05 design review (the decision record is on the proposal page, section 14). Resumes in phase 2 with the CHASM notification work. The branch stays as a pin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pins the api fork that declares the notification channel API, plus what the pin forces.
What changed?
go.modpointsgo.temporal.io/apiatgithub.com/moetemp/api-go.workflowservicemock.cmd/tools/getprotomaps the newnotification/v1package.NotifyChannel,RegisterChannelListener,UnregisterChannelListener,PollChannel,DescribeChannel) get their rows in the method metadata, the frontend and persistence quotas, the redirection and DC policy tables and the telemetry list. The frontend answers them withUnimplementedfor now.WORKFLOW_NOTIFICATION_CHANNEL_SUBSCRIBEDand_UNSUBSCRIBEDevents are never buffered, like every other event a command writes.Part of AI-198 (epic AI-37).
Why?
Nothing here is a feature. Everything in it is forced by the pin. The service has to implement every RPC the api declares, and the tables and tests that walk every method or event type fail on one without a row. Channel writes get the same priority and forwarding as a Signal, and
PollChannelsits with the other long polls. The channel service in the next PRs replaces the stubs.How did you test it?
Link to a test plan if any -
I ran the unit tests for
common/rpc,common/api, the history builder, the persistence client and the frontend. That includesTestGlobalAPIandTestBufferEvent, which walk every method and event type. The functional tests compile. Lint and theerrortypevet are clean.