Skip to content

Pinned api-go to the branch carrying the stream protos. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
moetemp wants to merge 14 commits into from
Closed

Pinned api-go to the branch carrying the stream protos. #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
321aae9
Re-pinned api-go to the documented stream protos.
moetemp Sep 25, 2026
80895a0
Required protobuf payloads from the system Nexus endpoint.
moetemp Sep 25, 2026
27ac37f
Scoped the exemplar comparison to the exemplar field.
moetemp Sep 25, 2026
183efab
Repinned the api to the renamed stream fields.
moetemp Sep 25, 2026
1a39324
Merged current main into the stream api pin.
moetemp Sep 25, 2026
aac9783
Read the pinned append command through its renamed field.
moetemp Sep 26, 2026
6155342
Repinned the api to the subscribe start position.
moetemp Sep 28, 2026
e854127
Kept the two stream command events out of the event buffer.
moetemp Sep 29, 2026
6c65c43
Pinned the api-go fork with the wake protos.
moetemp Oct 1, 2026
0fbd90f
Pinned the api-go fork with the notification channel protos.
moetemp Oct 2, 2026
fc0c50e
Pinned api-go without the point-to-point wake and dropped its rows.
moetemp Oct 2, 2026
40516ba
Pinned api-go with the describe channel field and the unsubscribe com…
moetemp Oct 2, 2026
3a1f6f5
Pinned api-go with the Execution reference on the channel calls.
moetemp Oct 3, 2026
9a0a29c
Pinned api-go with the Execution fields on their final numbers.
moetemp Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,14 +525,18 @@ workflowcheck: $(WORKFLOWCHECK)
check: lint shell-check

##### Tests #####
# verify-test-log reads the whole file, so a log left behind by an earlier run
# would be judged as if it belonged to this one.
clean-test-output:
@printf $(COLOR) "Delete test output..."
@rm -rf $(TEST_OUTPUT_ROOT)
@rm -f test.log
@go clean -testcache

build-tests:
@printf $(COLOR) "Build tests..."
@CGO_ENABLED=$(CGO_ENABLED) go test $(TEST_TAG_FLAG) -exec="true" -count=0 $(TEST_DIRS)
@CGO_ENABLED=$(CGO_ENABLED) go test $(TEST_TAG_FLAG) -exec="true" -count=0 $(filter-out $(MIXED_BRAIN_TEST_ROOT)%,$(TEST_DIRS))
@cd $(MIXED_BRAIN_TEST_ROOT) && CGO_ENABLED=1 go test $(TEST_TAG_FLAG) -exec="true" -count=0 ./...

unit-test: clean-test-output
@printf $(COLOR) "Run unit tests..."
Expand Down
50 changes: 50 additions & 0 deletions client/frontend/client_gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

70 changes: 70 additions & 0 deletions client/frontend/metric_client_gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

75 changes: 75 additions & 0 deletions client/frontend/retryable_client_gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions cmd/tools/getproto/files.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions common/api/metadata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,11 @@ var (
"RespondNexusTaskFailed": {Scope: ScopeNamespace, Access: AccessWrite, Polling: PollingNone},
"RequestCancelWorkflowExecution": {Scope: ScopeNamespace, Access: AccessWrite, Polling: PollingNone},
"SignalWorkflowExecution": {Scope: ScopeNamespace, Access: AccessWrite, Polling: PollingNone},
"NotifyChannel": {Scope: ScopeNamespace, Access: AccessWrite, Polling: PollingNone},
"RegisterChannelListener": {Scope: ScopeNamespace, Access: AccessWrite, Polling: PollingNone},
"UnregisterChannelListener": {Scope: ScopeNamespace, Access: AccessWrite, Polling: PollingNone},
"PollChannel": {Scope: ScopeNamespace, Access: AccessReadOnly, Polling: PollingCapable},
"DescribeChannel": {Scope: ScopeNamespace, Access: AccessReadOnly, Polling: PollingNone},
"SignalWithStartWorkflowExecution": {Scope: ScopeNamespace, Access: AccessWrite, Polling: PollingNone},
"ResetWorkflowExecution": {Scope: ScopeNamespace, Access: AccessWrite, Polling: PollingNone},
"TerminateWorkflowExecution": {Scope: ScopeNamespace, Access: AccessWrite, Polling: PollingNone},
Expand Down
14 changes: 10 additions & 4 deletions common/metrics/otel_metrics_handler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,14 @@ func TestMeter(t *testing.T) {
cmpopts.SortSlices(func(x, y metricdata.Metrics) bool {
return x.Name < y.Name
}),
cmpopts.IgnoreFields(metricdata.DataPoint[int64]{}, "StartTime", "Time"),
cmpopts.IgnoreFields(metricdata.DataPoint[float64]{}, "StartTime", "Time"),
cmpopts.IgnoreFields(metricdata.HistogramDataPoint[int64]{}, "StartTime", "Time", "Bounds"),
// Exemplars are ignored rather than equated empty: the SDK hands back
// either a nil or an allocated-but-empty slice depending on whether
// its reservoir was ever touched, and equating empty globally would
// also hide a nil-versus-empty attribute set or data point.
cmpopts.IgnoreFields(metricdata.DataPoint[int64]{}, "StartTime", "Time", "Exemplars"),
cmpopts.IgnoreFields(metricdata.DataPoint[float64]{}, "StartTime", "Time", "Exemplars"),
cmpopts.IgnoreFields(
metricdata.HistogramDataPoint[int64]{}, "StartTime", "Time", "Bounds", "Exemplars"),
); diff != "" {
t.Errorf("mismatch (-want, +got):\n%s", diff)
}
Expand Down Expand Up @@ -264,7 +269,8 @@ func TestMeter_TimerInSeconds(t *testing.T) {
cmp.Comparer(func(a1, a2 attribute.Set) bool {
return a1.Equals(&a2)
}),
cmpopts.IgnoreFields(metricdata.HistogramDataPoint[float64]{}, "StartTime", "Time", "Bounds"),
cmpopts.IgnoreFields(
metricdata.HistogramDataPoint[float64]{}, "StartTime", "Time", "Bounds", "Exemplars"),
); diff != "" {
t.Errorf("mismatch (-want, +got):\n%s", diff)
}
Expand Down
Loading
Loading