Repository navigation
fix: v1.1.2 unparseable — secrets context does not exist in step if - #4
Open
tmihalicka wants to merge 2 commits into
Open
tmihalicka wants to merge 2 commits into
tmihalicka wants to merge 2 commits into
Conversation
GitHub refuses to parse a workflow whose step `if:` references the
`secrets` context ("Unrecognized named-value: 'secrets'"), so every
caller of build.yml@v1.1.2 fails with a zero-job run before anything
executes. The bypass shipped in #3 therefore never ran at all.
- build/publish: job-level `env.DIRECT_REGISTRY_CREDS` computes the
presence test once (job env does get `secrets`); steps branch on it.
- writeback: the preflight skip was wrong anyway — the GitHub App key
still comes from 1Password unconditionally, so the OP token preflight
now always runs.
- fix an unterminated quote in the bypass step's echo that would have
failed the step at runtime.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LsMgGVLnvZHf9LLjBW4eae
…w twice
actionlint flags the exact defect v1.1.2 shipped with ("context 'secrets'
is not allowed here"), and this repo had no CI to run it. Toolchain comes
from `go run <module>@<version>`, pinned and verified against the Go
checksum database rather than trusting a third-party action.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LsMgGVLnvZHf9LLjBW4eae
Member
Author
|
Added an actionlint CI job to this PR — it catches exactly the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
build.yml@v1.1.2(and current main) cannot be parsed by GitHub Actions: step-levelif:has nosecretscontext, so every caller fails with:The caller sees this as a run with zero jobs (what jednoduchopis-crm run 38396125618 hit). The 1Password bypass from #3 never executed at all — the earlier "missing tag" diagnosis was only the first layer.
Fix
env: DIRECT_REGISTRY_CREDS: ${{ secrets.SCW_ACCESS_KEY != '' }}(jobenvdoes getsecrets); the three bypass-related steps branch onenv.DIRECT_REGISTRY_CREDSinstead.echo(would have failed at runtime once reachable).actionlint passes.
After merge
Needs a signed
v1.1.3tag (owner-created, same as v1.1.2); callers on v1.1.2 must bump — jednoduchopis-crm will be pinned to the merge SHA in the meantime to unblock the prod deploy.🤖 Generated with Claude Code
https://claude.ai/code/session_01LsMgGVLnvZHf9LLjBW4eae