fix(query-parser): use json stringify to return code block COMPASS-10946 - #852
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the query-parser BSON-to-JS stringification logic so Code values are emitted using JSON.stringify, improving escaping/quoting of the embedded code string when rendering a JS-like representation.
Changes:
- Stringify BSON
Codevalues usingJSON.stringify(v.code)and reuse the result for both scoped and unscoped forms.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
50
to
+55
| Code: function (v: Code) { | ||
| const code = JSON.stringify(v.code); | ||
| if (v.scope) { | ||
| return `Code('${v.code}',${JSON.stringify(v.scope)})`; | ||
| return `Code(${code},${JSON.stringify(v.scope)})`; | ||
| } | ||
| return `Code('${v.code}')`; | ||
| return `Code(${code})`; |
dudaschar
changed the title
dudaschar
marked this pull request as ready for review
August 4, 2026 12:32
mabaasit
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Using JSON.stringify to scape code before returning string, more details on ticket.
Open Questions
Checklist