fix: Default force_bump to false for scheduled release runs - #1506
Merged
Merged
Conversation
Scheduled workflows provide no workflow_dispatch inputs, so force_bump resolves to an empty string and fails boolean input validation for release-spec.yml. The four env release jobs are then never created and the failure is invisible to the retry/failure handlers. Coerce with || false so a valid boolean is always passed.
yelizhenden-mdb
marked this pull request as ready for review
September 24, 2026 13:11
yelizhenden-mdb
requested review from
andmatei,
andreaangiolillo,
chrysanthi-m,
drinkbird,
maks-m-mongo-leaf,
saisundar and
wtrocki
September 24, 2026 13:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scheduled Release Runner runs have been failing since 2026-09-22 (after #1493): the four
Release OpenAPI Spec for <env>jobs never start, and only the deprecated V1 release runs. The failure is silent — no job ever fails, so the retry/failure handlers never create a GH issue or Jira ticket.Root cause
force_bumpis aworkflow_dispatchboolean input. Scheduled workflows send it as null and it resolves to an empty string, so the runner passedforce_bump: ''torelease-spec.yml, which declares the input astype: boolean. GitHub rejects''while evaluating the reusable-workflow inputs:This happens while GitHub builds the job graph, before any of the four jobs are created, so:
release-spec-v1-prodstarts (it doesn't takeforce_bump), which made it look like "only the deprecated workflow runs";retry-handler/failure-handleronly watchrelease-preparation(which succeeds), so nothing is reported — no failed job, no issue, no Jira ticket. The only trace is the error annotation on the run page.Evidence: every scheduled run fails since the first schedule after #1493 merged (2026-09-22T12:15Z), while every manual
workflow_dispatchsucceeds — the dispatch UI supplies a real boolean, so validation passes.Fix
Coerce to a real boolean at the four call sites in
release-spec-runner.yml:schedule: empty/null input →false(valid boolean, validation passes)workflow_dispatch: the real boolean from the UI passes through unchanged, so the force-bump feature keeps workingTesting