Repository navigation
Conversation
…ble keyboard shortcut Firefox 116.0 changed the long standing behaviour of how closed tabs were re- opened using (per default Ctrl-Shift-T) from re-opening the last closed tab of the current window, to re-opening the last closed tab of all windows. See [0]. This needlessly broke the work flow for many people sorting their tabs in multiple windows, where re-opening the last tab in an unrelated window typically makes no sense, and also prevented easy re-opening of such tabs, because only the last overall closed tab could be re-opened. A considerable number of blog posts, stack overflow questions and the likes dealing with whether and how the older behaviour can be reverted. This commit exports the previous behaviour as a configurable keyboard shortcut via `about:keyboard`, leaving the post-116.0 behaviour, albeit questionable, as default while allow people to easily revert. AI assistance was used, mostly for even finding the relevant code sections. [0] Commit a0b6ef9 (“Bug 1833416 - modify undoClosedTab keyboard shortcut r=mconley,sfoster,sessionstore-reviewers,dao”) Signed-off-by: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name> Fixes: https://bugzilla.mozilla.org/show_bug.cgi?id=2025220 Assisted-by: Claude Sonnet 5.5 Medium
No Taskcluster jobs started for this pull requestThe |
Contributor
|
(Automated Close) Please do not file pull requests here, see https://firefox-source-docs.mozilla.org/contributing/how_to_submit_a_patch.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey.
Recently I often saw Mozilla ads on Facebook on how good FF was and how much the needs of users are now taken care of. 😉️
Well, one of the IMO biggest showstoppers every introduced was breaking the long standing re-open closed tab behaviour with bug #1833416 for IMO no good reason.
I saw considerable number of blog posts and the likes dealing with that question, and because of the above ads and because Mozilla actually implementing bug #1844959, which really added quite some usability effort, I figured, maybe you'd accept a patch which at least allows people to get back the old behaviour (while keeping the current one as default[0]).
I applied my patch to the Debian unstable Firefox package (version 158.0.1), built it and it seems to work[1] as it should.
I also looked through https://firefox-source-docs.mozilla.org/ and in particular How to submit a patch, but TBH, was a bit overwhelmed by the length of it (and when I access https://phabricator.services.mozilla.com/ I get an error).
So I'm trying now via a PR... and would be most thankful if someone could help me getting this reviewed and merged. 🤗️
Best wishes,
Chris.
[0] I still think the current one is plain useless for most people, so if you wanna change defaults, I wouldn't complain. 😇️
[1] There is one issue, but I'm pretty confident it’s just another bug,... will report that after this PR and then reference it here.
Lando: link
🚫 This pull request has 2 blockers.