Repository navigation
Conversation
…creen toolbar shifts. r?#urlbar-reviewers,#desktop-theme-reviewers When transform-aware anchor positioning is disabled, the top-layer view does not follow the toolbar translate. Apply the toolbar shift to the view in that configuration. Differential Revision: https://phabricator.services.mozilla.com/D337411
No Taskcluster jobs started for this pull requestThe |
Contributor
|
(Automated Close) Please do not file pull requests here, see https://firefox-source-docs.mozilla.org/contributing/how_to_submit_a_patch.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the macOS fullscreen titlebar appears, the toolbar moves down but the top-layer suggestions can stay in place and cover the address bar input. Apply the toolbar shift to the suggestions when transform-aware anchor positioning is disabled.
The test covers both values of the preference, Nova on and off, and resetting the toolbar shift.
Bugzilla: bug 2086366. The same patch is also under review in Phabricator D337411.
Validation on macOS arm64:
The tests call the toolbar shift handler in a headless browser; they do not exercise the native titlebar animation.
Screenshots from the affected Firefox 158.0.1 profile: before revealing the titlebar and after revealing it.
Lando: link
Bugzilla: bug 2086366
🚫 This pull request has 1 blocker.