Repository navigation
Conversation
jcristau
reviewed
Oct 28, 2026
Comment on lines
+379
to
+382
| if ( | ||
| gradle_build_type in MINIFIED_BUILD_TYPES | ||
| and "-PdisableOptimization" not in task["run"]["gradlew"] | ||
| ): |
Contributor
There was a problem hiding this comment.
Might be worth making that unconditional, worst case it doesn't exist and we just get a warning in the log?
Contributor
Author
There was a problem hiding this comment.
thanks, trying that now, if it just gives a warning and not a failure that makes sense
Contributor
Author
There was a problem hiding this comment.
ok that works nicely, have simplified and got a successful try
|
No new issues detected. This pull request is 🆗 |
1 similar comment
|
No new issues detected. This pull request is 🆗 |
NB the mapping file is only produced for r8 optimised builds: debug builds do not produce a mapping.txt, so in this case there will simply be a warning in the logs that the mapping.txt file does not exist. changes: - `build_android_app.py`: `add_artifacts` now adds `mapping.txt` to any build. - `build-apk/kind.yml`: removed the one-off artifact on `fenix-nightly-firebase`. The new rule produces the same path, and the `ui-test-apk` fetch still resolves. - `test_android_taskgraph.py`: a new test, `test_mapping_published_for_each_variant`, looks for the mapping file at the expected path.
pollym
force-pushed
the
publish-mappings-for-all-minified-builds
branch
from
October 29, 2026 08:47
6e55703 to
402521a
Compare
|
No new issues detected. This pull request is 🆗 |
1 similar comment
|
No new issues detected. This pull request is 🆗 |
pollym
changed the title
jcristau
approved these changes
Oct 29, 2026
lando-worker Bot
pushed a commit
that referenced
this pull request
Oct 29, 2026
NB the mapping file is only produced for r8 optimised builds: debug builds do not produce a mapping.txt, so in this case there will simply be a warning in the logs that the mapping.txt file does not exist. changes: - `build_android_app.py`: `add_artifacts` now adds `mapping.txt` to any build. - `build-apk/kind.yml`: removed the one-off artifact on `fenix-nightly-firebase`. The new rule produces the same path, and the `ui-test-apk` fetch still resolves. - `test_android_taskgraph.py`: a new test, `test_mapping_published_for_each_variant`, looks for the mapping file at the expected path. [new try is here](https://treeherder.mozilla.org/jobs?repo=try&revision=a82c98e006dd980f36bb3feb47f7bd21711cd143) it is green and you can see the new artifact in each build: here is an example <img width="346" height="217" alt="image" src="https://github.com/user-attachments/assets/aa39de04-cee7-4a0c-a281-cae492a37cac" /> artifact sizes for two of the try mappings: - Fenix nightly bundle: about 221 MB - Focus release bundle: about 108 MB Pull request: #422
|
Pull request closed by commit d890dd6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NB the mapping file is only produced for r8 optimised builds: debug builds do not produce a mapping.txt, so in this case there will simply be a warning in the logs that the mapping.txt file does not exist.
changes:
build_android_app.py:add_artifactsnow addsmapping.txtto any build.build-apk/kind.yml: removed the one-off artifact onfenix-nightly-firebase. The new rule produces the same path, and theui-test-apkfetch still resolves.test_android_taskgraph.py: a new test,test_mapping_published_for_each_variant, looks for the mapping file at the expected path.new try is here
it is green and you can see the new artifact in each build: here is an example
artifact sizes for two of the try mappings:
Lando: link
Bugzilla: bug 2086064
🚫 This pull request has 2 blockers.