Repository navigation
Conversation
pollym
force-pushed
the
switch-on-obfuscation
branch
from
October 30, 2026 11:49
3fa6a1d to
114f9e7
Compare
This is in preparation for turning on obfuscation - which will be a simple follow up "switch it on" PR, for ease of backoutability :) This changeset adds the keep rules we will need for the app to still work ok with obfuscation on. Anywhere that navigation arguments using mozilla defined types are used, doesn't play nicely with obfuscation because androidx navigation uses reflection under the hood. So each module now offers a set of consumer proguard rules to allow it to be obfuscated by fenix or focus.
pollym
force-pushed
the
switch-on-obfuscation
branch
from
November 2, 2026 14:02
114f9e7 to
aa22a32
Compare
|
No new issues detected. This pull request is 🆗 |
1 similar comment
|
No new issues detected. This pull request is 🆗 |
Gela
approved these changes
Nov 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in preparation for turning on obfuscation - which will be a simple follow up "switch it on" PR, for ease of backoutability :)
This changeset adds the keep rules we will need for the app to still work ok with obfuscation on.
Anywhere that navigation arguments using mozilla defined types are used, doesn't play nicely with obfuscation because androidx navigation uses reflection under the hood. So each module now offers a set of consumer proguard rules to allow it to be obfuscated by fenix or focus.
try after rebase is here
Lando: link
Bugzilla: bug 2071819
🚫 This pull request has 2 blockers.