Repository navigation
Bug 2087051 - Speculative crash fix for a possible invalid page index when recording a page impression. Skip the impression and log a warning until the pager adjusts. - #427
Open
t-p-white wants to merge 1 commit into
Conversation
… when recording a page impression. Skip the impression and log a warning until the pager adjusts.
Contributor
Author
t-p-white
marked this pull request as ready for review
November 2, 2026 15:54
|
No new issues detected. This pull request is 🆗 |
1 similar comment
|
No new issues detected. This pull request is 🆗 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am unable to reproduce this locally - it looks like this is only affecting a very small number of devices but this defensive check will prevent crashing and report logging if it happens.
Lando: link
Bugzilla: bug 2087051
🚫 This pull request has 2 blockers.