feat: Adds secondary sqlite db to ads-client - #7567
Draft
thesuzerain wants to merge 11 commits into
Draft
Conversation
thesuzerain
commented
Aug 28, 2026
| pub placement_id: PlacementId, | ||
| pub ad_type: StorableAdType, | ||
| pub ad_body: Vec<u8>, | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This struct isn't strictly needed at this moment, but it makes the test generation a bit cleaner, and I could see it being useful for the next PR in the process (which will likely utilize conversions from AdImage, etc, to a more generic structure- this one)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR, and not yet ready for review.
This adds an 'adstore' equivalent to the to be used for storing ads in the new stateful ads-client design. It does not provide any FFI or interfaces or hooks or anything, simply the sqlite queries and internal logic, mimicking a lot of the logic for the
http_cache. This uses a separate sqlite db to the http_cache one, though they are functionally quite similar. The tests are all similar/the same, except for removed ones (such as TTL tests, see below).In particular, this does not include:
http_cache(we will have a background worker thread updating + clearing) it's not included in this PRhttp_cachehasrecord_http_cache_outcomefor cache hits/misses)I did, however, keep:
Pull Request checklist
[ci full]to the PR title.