Enrich Phabricator webhook comment context - #6516
Open
ayoubdiourin7 wants to merge 3 commits into
Open
Conversation
ayoubdiourin7
force-pushed
the
feature/phabricator-inline-comment-context
branch
from
August 6, 2026 11:42
8efb917 to
a5a8f36
Compare
ayoubdiourin7
marked this pull request as ready for review
August 6, 2026 11:48
suhaibmujahid
requested changes
Aug 6, 2026
| author_phid: str | ||
| comment_id: int | ||
| comment_type: Literal["comment", "inline"] | ||
| diff_id: int | None = None |
Member
There was a problem hiding this comment.
If we have it all the time, it would be nice. But if it will increase complexity (e.g., extra http requests), let us file a follow-up issue and do it later, not part of this PR.
Collaborator
Author
There was a problem hiding this comment.
All metadata added here is already returned by the existing transaction.search call, so no additional HTTP request or lookup is needed.
Member
There was a problem hiding this comment.
I mean to have it even for regular comments as well.
ayoubdiourin7
force-pushed
the
feature/phabricator-inline-comment-context
branch
from
August 6, 2026 21:49
83c7f11 to
c8b12fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
comment_id,type, and, for inline comments,diff_id.Resolve #6434